Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WS client: Add convenience method to connect to the event WebSocket #2993

Merged
merged 1 commit into from
Jan 8, 2025
Merged

WS client: Add convenience method to connect to the event WebSocket #2993

merged 1 commit into from
Jan 8, 2025

Conversation

florian-h05
Copy link
Contributor

Also improve the WS client code in general.

@florian-h05
WS client: Add convenience method to connect to the event WebSocket &…
086bdbc 
… Improve code

Signed-off-by: Florian Hotze <dev@florianhotze.com>
@florian-h05 florian-h05 requested a review from ghys as a code owner January 8, 2025 23:22
@florian-h05 florian-h05 added enhancement New feature or request main ui Main UI labels Jan 8, 2025
@florian-h05 florian-h05 added this to the 5.0 milestone Jan 8, 2025
@relativeci RelativeCI
Copy link

relativeci bot commented Jan 8, 2025

#2667 Bundle Size — 10.97MiB (~+0.01%).

086bdbc(current) vs ea5121d main#2664(baseline)

Warning

Bundle contains 2 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Regression 1 regression
                 Current
#2667		      Baseline
#2664
Regression  Initial JS 1.9MiB(+0.02%) 1.9MiB
No change  Initial CSS 577.21KiB 577.21KiB
Change  Cache Invalidation 17.39% 17.68%
No change  Chunks 227 227
No change  Assets 250 250
No change  Modules 2950 2950
No change  Duplicate Modules 154 154
No change  Duplicate Code 1.78% 1.78%
No change  Packages 98 98
No change  Duplicate Packages 2 2
Bundle size by type  Change 1 change Regression 1 regression
                 Current
#2667		      Baseline
#2664
Regression  JS 9.19MiB (~+0.01%) 9.19MiB
No change  CSS 867.02KiB 867.02KiB
No change  Fonts 526.1KiB 526.1KiB
No change  Media 295.6KiB 295.6KiB
No change  IMG 140.74KiB 140.74KiB
No change  HTML 1.38KiB 1.38KiB
No change  Other 871B 871B

Bundle analysis report Branch florian-h05:ws-events Project dashboard

Generated by RelativeCI Documentation Report issue

@florian-h05 florian-h05 merged commit a9954c3 into openhab:main Jan 8, 2025
5 checks passed
@florian-h05 florian-h05 deleted the ws-events branch January 8, 2025 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghys ghys Awaiting requested review from ghys ghys is a code owner

Assignees
No one assigned
Labels
enhancement New feature or request main ui Main UI
Projects
None yet
Milestone
5.0
Development

Successfully merging this pull request may close these issues.
1 participant
@florian-h05